Use the schema_search_path in prepared statements. #3232
Conversation
To allow the use of prepared statements when changing schemas in postgres, the schema search path is added to the sql key.
|
Can you write a test for this? We have schema tests for PG in the active record suite. |
Add tests for prepared statements with multiple schemas in postgreSQL.
|
Done! |
|
Great! Thank you! ❤️ |
Use the schema_search_path in prepared statements.
|
Thank you for creating this patch! This problem was driving me crazy until I found your post on the topic. Until this patch is "officially released" in an upcoming version of Rails, I'm working around the problem by calling ActiveRecord::Base.connection.clear_cache! # HACK: Workaround ...just before setting a new search path. I'm not familiar with the Rails release process, but I hope this fix is included in the next version. |
|
I hope so too! Meanwhile, I'm using the same workaround. Good to know the patch works for you. :) |
|
@jonleighton, any chance to include this in next 3.1.2 release? |
|
The RC has already gone out but I am pretty sure this is in there - check the CHANGELOG though. |
|
Actually, doesn't look like it is in the release, sorry. It's too late now to put it in I'm afraid. If you'd like it in the next release, please submit a pull request with a backport. Thanks. |
|
After digging a while into git history, I think this is what happened: In Instead of porting the two commits to This pull request also includes tests, but they were not ported to So, the problem solved by this pull request seems to be already solved in Do I create a pull request to back-port tests? |
|
Ok, thanks for looking into it :) If you can create a PR with the tests and a CHANGELOG entry (under 3.1.2) that would be great. Thanks. |
Backport #3232 to 3-1-stable
Backport #3232 to 3-1-stable
I'm using postgreSQL with multiple schemas.
Rails 3.1 uses prepared statements and does not take into account the 'schema_search_path'. This is a big problem because the statement is prepared once and then the same prepared statement is executed many times no matter if you changed the schema, i.e, the prepared statement is executed ALWAYS for the same schema, the one set when the statement was prepared.
This patch adds the schema search to the sql key to allow the use of prepared statements when changing schemas in postgreSQL,
Discussion here:
https://groups.google.com/forum/#!msg/rubyonrails-core/r2VOKcyUyrs/JQj4MB_lhRMJ